Issue 182460043: code review 182460043: [release-branch.go1.4] lib/time: update to ICANN time z...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 182460043: code review 182460043: [release-branch.go1.4] lib/time: update to ICANN time z... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by adg

Modified:
9 years, 4 months ago

Reviewers:
dsymonds, minux

CC:
dsymonds, r, minux, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.4] lib/time: update to ICANN time zone database 2014j ««« CL 178660043 / ac865d86fc2a lib/time: update to ICANN time zone database 2014j Fixes issue 9189. LGTM=dsymonds R=golang-codereviews, dsymonds CC=golang-codereviews https://codereview.appspot.com/178660043 »»»

Patch Set 1 #

Patch Set 2 : diff -r a8374fb64418fe978e81ed13c5b31bdc2bccab54 https://code.google.com/p/go #

Patch Set 3 : diff -r a8374fb64418fe978e81ed13c5b31bdc2bccab54 https://code.google.com/p/go #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	lib/time/update.bash	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	lib/time/zoneinfo.zip	View	1	Binary file		0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello dsymonds, r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 4 months ago (2014-12-04 04:29:55 UTC) #1

adg

9 years, 4 months ago (2014-12-04 04:32:41 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=1daa56ce9299 ***

[release-branch.go1.4] lib/time: update to ICANN time zone database 2014j

««« CL 178660043 / ac865d86fc2a
lib/time: update to ICANN time zone database 2014j

Fixes issue 9189.

LGTM=dsymonds
R=golang-codereviews, dsymonds
CC=golang-codereviews
https://codereview.appspot.com/178660043
»»»

LGTM=minux, dsymonds
R=dsymonds, r, minux
CC=golang-codereviews
https://codereview.appspot.com/182460043

Expand All Messages | Collapse All Messages