Issue 182450043: code review 182450043: x/net/ipv6: split Set method of ICMPFilter into Accept,...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 182450043: code review 182450043: x/net/ipv6: split Set method of ICMPFilter into Accept,... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by mikio

Modified:
10 years, 3 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

x/net/ipv6: split Set method of ICMPFilter into Accept, Block methods This is an API breaking change. method (*ICMPFilter) Set(ICMPType, bool) is now replaced with method (*ICMPFilter) Accept(ICMPType) method (*ICMPFilter) Block(ICMPType)

Patch Set 1 : diff -r c4470e8a716a10935ddac89ed085e697e81766b9 https://code.google.com/p/go.net #

Patch Set 2 : diff -r 2cc654565017a54ae58969615baace0a5857f4b8 https://code.google.com/p/go.net #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -54 lines)			Patch
M	ipv6/example_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ipv6/icmp.go	View	2 chunks	+19 lines, -18 lines	0 comments	Download
M	ipv6/icmp_bsd.go	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	ipv6/icmp_linux.go	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	ipv6/icmp_solaris.go	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	ipv6/icmp_stub.go	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	ipv6/icmp_test.go	View	3 chunks	+10 lines, -17 lines	0 comments	Download
M	ipv6/icmp_windows.go	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	ipv6/multicast_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipv6/unicast_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

10 years, 3 months ago (2014-12-04 02:57:08 UTC) #1

mikio

10 years, 3 months ago (2014-12-04 08:32:13 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=ca2dc8b9e7d3&repo=net ***

x/net/ipv6: split Set method of ICMPFilter into Accept, Block methods

This is an API breaking change.

method (*ICMPFilter) Set(ICMPType, bool)

is now replaced with

method (*ICMPFilter) Accept(ICMPType)
method (*ICMPFilter) Block(ICMPType)

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/182450043

Expand All Messages | Collapse All Messages