Issue 182410043: code review 182410043: x/net/icmp: update package documentation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 182410043: code review 182410043: x/net/icmp: update package documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by mikio

Modified:
9 years, 5 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

x/net/icmp: update package documentation Also fixes typos.

Patch Set 1 : diff -r ff3b47fbfca01acfa052297ae28a270172236d42 https://code.google.com/p/go.net #

Total comments: 6

Patch Set 2 : diff -r ff3b47fbfca01acfa052297ae28a270172236d42 https://code.google.com/p/go.net #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
M	icmp/listen_stub.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	icmp/listen_unix.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	icmp/message.go	View	1	2 chunks	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

9 years, 5 months ago (2014-12-03 10:56:50 UTC) #1

iant

LGTM https://codereview.appspot.com/182410043/diff/40001/icmp/message.go File icmp/message.go (right): https://codereview.appspot.com/182410043/diff/40001/icmp/message.go#newcode9 icmp/message.go:9: // The ICMPv4 and ICMPv6 are defined in ...

9 years, 5 months ago (2014-12-03 16:03:48 UTC) #2

mikio

9 years, 5 months ago (2014-12-04 00:09:03 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=c4470e8a716a&repo=net ***

x/net/icmp: update package documentation

Also fixes typos.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/182410043

https://codereview.appspot.com/182410043/diff/40001/icmp/message.go
File icmp/message.go (right):

https://codereview.appspot.com/182410043/diff/40001/icmp/message.go#newcode9
icmp/message.go:9: // The ICMPv4 and ICMPv6 are defined in RFC 792 and RFC 4443.
On 2014/12/03 16:03:48, iant wrote:
> Either remove "The" or add "protocols" before "are".

Done.

https://codereview.appspot.com/182410043/diff/40001/icmp/message.go#newcode44
icmp/message.go:44: // For ICMPv4 message, the returned message always contains
the
On 2014/12/03 16:03:48, iant wrote:
> s/ICMPv4/an ICMPv4/

Done.

https://codereview.appspot.com/182410043/diff/40001/icmp/message.go#newcode47
icmp/message.go:47: // For ICMPv6 message, the returned message contains the
calculated
On 2014/12/03 16:03:48, iant wrote:
> s/ICMPv6/an ICMPv6/

Done.

Expand All Messages | Collapse All Messages