Issue 182370043: code review 182370043: x/net/icmp: new package

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 182370043: code review 182370043: x/net/icmp: new package (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by mikio

Modified:
9 years, 5 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

x/net/icmp: new package This CL makes icmp an external package.

Patch Set 1 : diff -r 8baa758262a0c0b19ee8f0c4bf0ec6f3da109e52 https://code.google.com/p/go.net #

Patch Set 2 : diff -r 8baa758262a0c0b19ee8f0c4bf0ec6f3da109e52 https://code.google.com/p/go.net #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-12 lines, --12 lines)			Patch
M	icmp/dstunreach.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/echo.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/endpoint.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/example_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	icmp/helper_unix.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/ipv4.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/ipv4_test.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/ipv6.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/listen_stub.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/listen_unix.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/message.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/message_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	icmp/messagebody.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/packettoobig.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/paramprob.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/ping_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	icmp/sys_freebsd.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	icmp/timeexceeded.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

9 years, 5 months ago (2014-12-03 00:52:38 UTC) #1

mikio

9 years, 5 months ago (2014-12-03 03:32:58 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=00267844f20b&repo=net ***

x/net/icmp: new package

This CL makes icmp an external package.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/182370043

Expand All Messages | Collapse All Messages