Issue 182110043: code review 182110043: x/net/internal/icmp: add support for non-privileged ICM...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 182110043: code review 182110043: x/net/internal/icmp: add support for non-privileged ICM... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by mikio

Modified:
9 years, 4 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

x/net/internal/icmp: add support for non-privileged ICMP endpoint, known as ping socket This CL adds PacketConn struct that implements net.PacketConn interface. Update issue 9166

Patch Set 1 : diff -r 15d5d0fa7dd8b1ec3f9370cb3082025163881563 https://code.google.com/p/go.net #

Total comments: 4

Patch Set 2 : diff -r 6a05becb28d5d906c2dc7eec3fcdbff9a01ed132 https://code.google.com/p/go.net #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+510 lines, -0 lines)			Patch
A	internal/icmp/endpoint.go	View	1	1 chunk	+108 lines, -0 lines	0 comments	Download
A	internal/icmp/example_test.go	View		1 chunk	+54 lines, -0 lines	0 comments	Download
A	internal/icmp/helper_unix.go	View	1	1 chunk	+87 lines, -0 lines	0 comments	Download
A	internal/icmp/listen_stub.go	View		1 chunk	+33 lines, -0 lines	0 comments	Download
A	internal/icmp/listen_unix.go	View	1	1 chunk	+98 lines, -0 lines	0 comments	Download
A	internal/icmp/ping_test.go	View	1	1 chunk	+130 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

9 years, 4 months ago (2014-12-02 10:54:00 UTC) #1

iant

LGTM https://codereview.appspot.com/182110043/diff/460001/internal/icmp/endpoint.go File internal/icmp/endpoint.go (right): https://codereview.appspot.com/182110043/diff/460001/internal/icmp/endpoint.go#newcode35 internal/icmp/endpoint.go:35: p, ok := c.ipc.(*ipv4.PacketConn) You can simply write ...

9 years, 4 months ago (2014-12-02 16:25:46 UTC) #2

mikio

9 years, 4 months ago (2014-12-03 00:34:34 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=8baa758262a0&repo=net ***

x/net/internal/icmp: add support for non-privileged ICMP endpoint, known as ping
socket

This CL adds PacketConn struct that implements net.PacketConn
interface.

Update issue 9166

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/182110043

https://codereview.appspot.com/182110043/diff/460001/internal/icmp/endpoint.go
File internal/icmp/endpoint.go (right):

https://codereview.appspot.com/182110043/diff/460001/internal/icmp/endpoint.g...
internal/icmp/endpoint.go:35: p, ok := c.ipc.(*ipv4.PacketConn)
On 2014/12/02 16:25:46, iant wrote:
> You can simply write
>     p, _ := c.ipc.(*ipv4.PacketConn)
>     return p
> If the type assertion fails, p will always be set to the zero value, which for
a
> pointer is nil.

Done.

https://codereview.appspot.com/182110043/diff/460001/internal/icmp/endpoint.g...
internal/icmp/endpoint.go:48: p, ok := c.ipc.(*ipv6.PacketConn)
On 2014/12/02 16:25:46, iant wrote:
>     p, _ := c.ipc.(*ipv6.PacketConn)
>     return p

Done.

Expand All Messages | Collapse All Messages