Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1699)

Issue 182041: code review 182041: Cleanup: remove Exp ending in identifiers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 2 months ago by gri
Modified:
15 years, 2 months ago
Reviewers:
CC:
r
Visibility:
Public.

Description

Cleanup: remove Exp ending in identifiers as it is not needed anymore (only one impl. of vector package). Makefile, vector_test.go, and nogen_test.go were modified manually (find/replace), the other files (intvector_test.go, strinvector_test.go are generated). Runs all tests.

Patch Set 1 #

Patch Set 2 : code review 182041: Cleanup: remove Exp ending in identifiers #

Patch Set 3 : code review 182041: Cleanup: remove Exp ending in identifiers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -198 lines) Patch
M src/pkg/container/vector/Makefile View 2 chunks +26 lines, -26 lines 0 comments Download
M src/pkg/container/vector/intvector_test.go View 12 chunks +56 lines, -56 lines 0 comments Download
M src/pkg/container/vector/nogen_test.go View 2 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/container/vector/stringvector_test.go View 12 chunks +56 lines, -56 lines 0 comments Download
M src/pkg/container/vector/vector_test.go View 12 chunks +56 lines, -56 lines 0 comments Download

Messages

Total messages: 3
gri
Hello r, I'd like you to review the following change.
15 years, 2 months ago (2009-12-23 02:42:22 UTC) #1
r2
LGTM On Dec 23, 2009, at 1:42 PM, gri@golang.org wrote: > Reviewers: r, > > ...
15 years, 2 months ago (2009-12-23 02:43:39 UTC) #2
gri
15 years, 2 months ago (2009-12-23 02:45:41 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=39b7a540f186 ***

Cleanup: remove Exp ending in identifiers
as it is not needed anymore (only one impl.
of vector package).

Makefile, vector_test.go, and nogen_test.go
were modified manually (find/replace), the
other files (intvector_test.go, strinvector_test.go
are generated).

Runs all tests.

R=r
http://codereview.appspot.com/182041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b