Issue 181870043: code review 181870043: [release-branch.go1.4] image/jpeg: handle Read returnin...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 181870043: code review 181870043: [release-branch.go1.4] image/jpeg: handle Read returnin... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by rsc

Modified:
9 years, 5 months ago

Reviewers:
r

CC:
golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.4] image/jpeg: handle Read returning n > 0, err != nil in d.fill ««« CL 178120043 / 95f5614b4648 image/jpeg: handle Read returning n > 0, err != nil in d.fill Fixes issue 9127. LGTM=r R=bradfitz, r CC=golang-codereviews, nigeltao https://codereview.appspot.com/178120043 »»»

Patch Set 1 #

Patch Set 2 : diff -r e08b7ca1d03a8d8bb5b83b492dae4589a5151afb https://code.google.com/p/go/ #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -0 lines)			Patch
	M	src/image/jpeg/reader.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	src/image/jpeg/reader_test.go	View	1	2 chunks	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 5 months ago (2014-11-23 16:15:35 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=926c82fb5dad *** [release-branch.go1.4] image/jpeg: handle Read returning n > 0, err != ...

9 years, 5 months ago (2014-11-23 16:15:45 UTC) #2

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages