Issue 181200043: code review 181200043: x/net/ipv4: remove unnecessary stubs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 181200043: code review 181200043: x/net/ipv4: remove unnecessary stubs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by mikio

Modified:
9 years, 5 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

x/net/ipv4: remove unnecessary stubs

Patch Set 1 : diff -r 5dedbdc181629d2f3557caf2667e60eb82c5e6d7 https://code.google.com/p/go.net #

Patch Set 2 : diff -r 5dedbdc181629d2f3557caf2667e60eb82c5e6d7 https://code.google.com/p/go.net #

Patch Set 3 : diff -r 5dedbdc181629d2f3557caf2667e60eb82c5e6d7 https://code.google.com/p/go.net #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -18 lines)			Patch
	M	ipv4/sockopt_stub.go	View		1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

9 years, 5 months ago (2014-11-26 05:02:02 UTC) #1

mikio

9 years, 5 months ago (2014-11-26 22:14:42 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=2ab5dc179077&repo=net ***

x/net/ipv4: remove unnecessary stubs

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/181200043

Expand All Messages | Collapse All Messages