Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(782)

Issue 180920043: code review 180920043: go/parser: Use test-specific filesets to avoid races. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by gri
Modified:
9 years, 4 months ago
Reviewers:
r, gobot, adonovan
CC:
adonovan, r, golang-codereviews
Visibility:
Public.

Description

go/parser: Use test-specific filesets to avoid races. Only affects test code. Fixes issue 9025. Fixes issue 9130.

Patch Set 1 #

Patch Set 2 : diff -r d71cc7e8a0e049ad429900ac11448062aafb4a01 https://code.google.com/p/go/ #

Patch Set 3 : diff -r d71cc7e8a0e049ad429900ac11448062aafb4a01 https://code.google.com/p/go/ #

Patch Set 4 : diff -r e4ab8f908aac3fb9ed42cbc08bee3f3060d26637 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M src/go/parser/error_test.go View 1 7 chunks +13 lines, -14 lines 0 comments Download
M src/go/parser/parser_test.go View 1 10 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 5
gri
Hello adonovan@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 4 months ago (2014-11-19 22:03:49 UTC) #1
r
LGTM
9 years, 4 months ago (2014-11-20 06:23:39 UTC) #2
adonovan
On 2014/11/20 06:23:39, r wrote: > LGTM LGTM
9 years, 4 months ago (2014-11-20 15:03:40 UTC) #3
gri
*** Submitted as https://code.google.com/p/go/source/detail?r=d7d71f7d6f53 *** go/parser: Use test-specific filesets to avoid races. Only affects test ...
9 years, 4 months ago (2014-11-20 17:35:26 UTC) #4
gobot
9 years, 4 months ago (2014-11-20 18:42:47 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/429a73a6092fc5c235690380d7af0e0ac57b190a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b