Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 180600043: code review 180600043: all: power64 is now ppc64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by rsc
Modified:
9 years, 5 months ago
Reviewers:
gobot, austin
CC:
austin, golang-codereviews
Visibility:
Public.

Description

all: power64 is now ppc64 Fixes issue 8654.

Patch Set 1 #

Patch Set 2 : diff -r 5b665926e5b4d472fc17385cd0b87337fa355b89 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5b665926e5b4d472fc17385cd0b87337fa355b89 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 5b665926e5b4d472fc17385cd0b87337fa355b89 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -123 lines) Patch
M include/link.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/cmd/9a/doc.go View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/9a/lex.c View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/cmd/9g/doc.go View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M src/cmd/9g/galign.c View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/cmd/9g/ggen.c View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/9g/peep.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/9l/asm.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/9l/doc.go View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M src/cmd/9l/obj.c View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/cmd/cgo/main.go View 1 1 chunk +10 lines, -14 lines 0 comments Download
M src/cmd/dist/build.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/dist/unix.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/internal/objfile/disasm.go View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M src/cmd/internal/objfile/elf.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/internal/objfile/macho.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/ld/ldelf.c View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/objdump/objdump_test.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug/elf/elf.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/go/build/build.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/go/build/syslist.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hash/crc32/crc32_generic.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/liblink/obj9.c View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M src/math/abs_ppc64x.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/math/big/arith_ppc64x.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/math/stubs_ppc64x.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/os/signal/sig.s View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/reflect/asm_ppc64x.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/arch1_ppc64.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/runtime/arch1_ppc64le.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/runtime/arch_ppc64.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/runtime/arch_ppc64le.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/runtime/asm_ppc64x.s View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/atomic_ppc64x.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/atomic_ppc64x.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/debug/stubs.s View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/defs3_linux.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/defs_linux_ppc64.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/runtime/defs_linux_ppc64le.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/runtime/gcinfo_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/lfstack_linux_ppc64x.go View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/memclr_ppc64x.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/memmove_ppc64x.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/noasm.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/panic.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/panic1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/rt0_linux_ppc64.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/rt0_linux_ppc64le.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/signal_linux_ppc64x.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/signal_ppc64x.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/sys_linux_ppc64x.s View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/sys_ppc64x.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/thunk.s View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/zgoarch_386.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/zgoarch_amd64.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/zgoarch_amd64p32.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/zgoarch_arm.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/zgoarch_ppc64.go View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime/zgoarch_ppc64le.go View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/sync/atomic/asm_ppc64x.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/syscall/asm.s View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/syscall/asm_linux_ppc64x.s View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/syscall/mkall.sh View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/syscall/syscall_linux_ppc64x.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/syscall/zerrors_linux_ppc64.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/syscall/zerrors_linux_ppc64le.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/syscall/zsyscall_linux_ppc64.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/syscall/zsyscall_linux_ppc64le.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/syscall/zsysnum_linux_ppc64.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/syscall/zsysnum_linux_ppc64le.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/syscall/ztypes_linux_ppc64.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/syscall/ztypes_linux_ppc64le.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/nilptr3.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/nosplit.go View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello austin (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 5 months ago (2014-12-05 21:37:43 UTC) #1
rsc
Hello austin, austin@google.com (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 5 months ago (2014-12-05 21:41:09 UTC) #2
austin
LGTM Builds and tests pass on power^H^H^H^H^Hppc64le.
9 years, 5 months ago (2014-12-05 21:52:51 UTC) #3
austin
BTW, there are still a few uses of "Power64" and "Power" (mostly in comments) that ...
9 years, 5 months ago (2014-12-05 22:10:27 UTC) #4
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=4d000340a768 *** all: power64 is now ppc64 Fixes issue 8654. LGTM=austin R=austin ...
9 years, 5 months ago (2014-12-06 00:13:28 UTC) #5
rsc
On Fri, Dec 5, 2014 at 5:10 PM, Austin Clements <austin@google.com> wrote: > BTW, there ...
9 years, 5 months ago (2014-12-06 00:16:17 UTC) #6
gobot
9 years, 5 months ago (2014-12-06 00:19:37 UTC) #7
Message was sent while issue was closed.
This CL appears to have broken the netbsd-386-minux builder.
See http://build.golang.org/log/e5d9524536012793173e3f588c7da08d65f5ba28
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b