code review 180500043: syscall: syscall.Readlink doesn't handle junction

syscall: syscall.Readlink doesn't handle junction
Fixes issue 9190

[mattn, 2014-12-02 12:47:37]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
http://go.googlecode.com/hg/

[mattn, 2014-12-02 13:09:13]

On 2014/12/02 12:47:37, mattn wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> http://go.googlecode.com/hg/

it must handle offset to begining filename when it's MOUNT_POINT.

[mattn, 2014-12-02 13:39:59]

On 2014/12/02 13:09:13, mattn wrote:
> On 2014/12/02 12:47:37, mattn wrote:
> > Hello mailto:golang-codereviews@googlegroups.com,
> > 
> > I'd like you to review this change to
> > http://go.googlecode.com/hg/
> 
> it must handle offset to begining filename when it's MOUNT_POINT.

Uploaded, Please take a look.

[bradfitz, 2014-12-02 17:19:04]

R=brainman


On Tue, Dec 2, 2014 at 5:39 AM, <mattn.jp@gmail.com> wrote:

> On 2014/12/02 13:09:13, mattn wrote:
>
>> On 2014/12/02 12:47:37, mattn wrote:
>> > Hello mailto:golang-codereviews@googlegroups.com,
>> >
>> > I'd like you to review this change to
>> > http://go.googlecode.com/hg/
>>
>
>  it must handle offset to begining filename when it's MOUNT_POINT.
>>
>
> Uploaded, Please take a look.
>
>
> https://codereview.appspot.com/180500043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[brainman, 2014-12-02 20:24:03]

Not without new test. Please add new test if possible. Thank you.

Alex

[mattn, 2014-12-03 01:00:04]

On 2014/12/02 20:24:03, brainman wrote:
> Not without new test. Please add new test if possible. Thank you.
> 
> Alex

Added test. It is not possible to do symbolic-link because it require
administrator's privilege.

[mattn, 2014-12-04 05:07:41]

On 2014/12/03 01:00:04, mattn wrote:
> On 2014/12/02 20:24:03, brainman wrote:
> > Not without new test. Please add new test if possible. Thank you.
> > 
> > Alex
> 
> Added test. It is not possible to do symbolic-link because it require
> administrator's privilege.

Caused by this issue, it seems we can't put GOROOT or GOPATH on junction-linked
directory unfortunately.
If this will be fixed, we will be possible to have some versions of go and
manage them using mklink on windows. :)

[minux, 2014-12-04 05:57:05]

On Thu, Dec 4, 2014 at 12:07 AM, <mattn.jp@gmail.com> wrote:
>
> Caused by this issue, it seems we can't put GOROOT or GOPATH on
> junction-linked directory unfortunately.
> If this will be fixed, we will be possible to have some versions of go
> and manage them using mklink on windows. :)

Having multiple go version is not that hard. No hard link is necessary.

Because the go command has GOROOT embedded into it, you can move
the go.exe to a directory in your %PATH% and rename it with a version
suffix appended, e.g. go1.4rc2.exe. Alternatively, you can use
go1.4rc2.bat/lnk.

[mattn, 2014-12-04 06:38:11]

On 2014/12/04 05:57:05, minux wrote:
> On Thu, Dec 4, 2014 at 12:07 AM, <mailto:mattn.jp@gmail.com> wrote:
> >
> > Caused by this issue, it seems we can't put GOROOT or GOPATH on
> > junction-linked directory unfortunately.
> > If this will be fixed, we will be possible to have some versions of go
> > and manage them using mklink on windows. :)
> 
> Having multiple go version is not that hard. No hard link is necessary.
> 
> Because the go command has GOROOT embedded into it, you can move
> the go.exe to a directory in your %PATH% and rename it with a version
> suffix appended, e.g. go1.4rc2.exe. Alternatively, you can use
> go1.4rc2.bat/lnk.

Yes, but I often make full use of disk. So this will be useful to fake
repository paths for GOPATH on windows. :)
Of course, I know GOPATH can contains multiple paths.

[gobot, 2014-12-19 05:16:57]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/180500043 is best) in the description in your
new CL.

Thanks very much.