code review 180108: add comment (warning about generated files)

add comment (warning about generated files)

[gri, 2009-12-21 23:06:34]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review the following change.

[gri, 2009-12-22 21:55:46]

ping

On Mon, Dec 21, 2009 at 3:06 PM, <gri@golang.org> wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review the following change.
>
>
> Description:
> add comment (warning about generated files)
>
> Please review this at http://codereview.appspot.com/180108
>
> Affected files:
>  M src/pkg/exp/vector/intvector.go
>  M src/pkg/exp/vector/intvector_test.go
>  M src/pkg/exp/vector/stringvector.go
>  M src/pkg/exp/vector/stringvector_test.go
>  M src/pkg/exp/vector/vector.go
>  M src/pkg/exp/vector/vector_test.go
>
>
> Index: src/pkg/exp/vector/intvector.go
> ===================================================================
> --- a/src/pkg/exp/vector/intvector.go
> +++ b/src/pkg/exp/vector/intvector.go
> @@ -2,6 +2,9 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// CAUTION: If this file is not vector.go, it was generated
> +// automatically from vector.go - DO NOT EDIT in that case!
> +
>  package vector
>
>
> Index: src/pkg/exp/vector/intvector_test.go
> ===================================================================
> --- a/src/pkg/exp/vector/intvector_test.go
> +++ b/src/pkg/exp/vector/intvector_test.go
> @@ -2,9 +2,11 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// CAUTION: If this file is not vector_test.go, it was generated
> +// automatically from vector_test.go - DO NOT EDIT in that case!
> +
>  package vector
>
> -
>  import "testing"
>
>
> Index: src/pkg/exp/vector/stringvector.go
> ===================================================================
> --- a/src/pkg/exp/vector/stringvector.go
> +++ b/src/pkg/exp/vector/stringvector.go
> @@ -2,6 +2,9 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// CAUTION: If this file is not vector.go, it was generated
> +// automatically from vector.go - DO NOT EDIT in that case!
> +
>  package vector
>
>
> Index: src/pkg/exp/vector/stringvector_test.go
> ===================================================================
> --- a/src/pkg/exp/vector/stringvector_test.go
> +++ b/src/pkg/exp/vector/stringvector_test.go
> @@ -2,9 +2,11 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// CAUTION: If this file is not vector_test.go, it was generated
> +// automatically from vector_test.go - DO NOT EDIT in that case!
> +
>  package vector
>
> -
>  import "testing"
>
>
> Index: src/pkg/exp/vector/vector.go
> ===================================================================
> --- a/src/pkg/exp/vector/vector.go
> +++ b/src/pkg/exp/vector/vector.go
> @@ -2,6 +2,9 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// CAUTION: If this file is not vector.go, it was generated
> +// automatically from vector.go - DO NOT EDIT in that case!
> +
>  package vector
>
>
> Index: src/pkg/exp/vector/vector_test.go
> ===================================================================
> --- a/src/pkg/exp/vector/vector_test.go
> +++ b/src/pkg/exp/vector/vector_test.go
> @@ -2,9 +2,11 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// CAUTION: If this file is not vector_test.go, it was generated
> +// automatically from vector_test.go - DO NOT EDIT in that case!
> +
>  package vector
>
> -
>  import "testing"
>
>
>
>
>

[r2, 2009-12-22 22:53:35]

LGTM


On Dec 23, 2009, at 8:55 AM, Robert Griesemer wrote:

> ping
>
> On Mon, Dec 21, 2009 at 3:06 PM, <gri@golang.org> wrote:
> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review the following change.
>
>
> Description:
> add comment (warning about generated files)
>
> Please review this at http://codereview.appspot.com/180108
>
> Affected files:
>  M src/pkg/exp/vector/intvector.go
>  M src/pkg/exp/vector/intvector_test.go
>  M src/pkg/exp/vector/stringvector.go
>  M src/pkg/exp/vector/stringvector_test.go
>  M src/pkg/exp/vector/vector.go
>  M src/pkg/exp/vector/vector_test.go
>
>
> Index: src/pkg/exp/vector/intvector.go
> ===================================================================
> --- a/src/pkg/exp/vector/intvector.go
> +++ b/src/pkg/exp/vector/intvector.go
> @@ -2,6 +2,9 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// CAUTION: If this file is not vector.go, it was generated
> +// automatically from vector.go - DO NOT EDIT in that case!
> +
>  package vector
>
>
> Index: src/pkg/exp/vector/intvector_test.go
> ===================================================================
> --- a/src/pkg/exp/vector/intvector_test.go
> +++ b/src/pkg/exp/vector/intvector_test.go
> @@ -2,9 +2,11 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// CAUTION: If this file is not vector_test.go, it was generated
> +// automatically from vector_test.go - DO NOT EDIT in that case!
> +
>  package vector
>
> -
>  import "testing"
>
>
> Index: src/pkg/exp/vector/stringvector.go
> ===================================================================
> --- a/src/pkg/exp/vector/stringvector.go
> +++ b/src/pkg/exp/vector/stringvector.go
> @@ -2,6 +2,9 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// CAUTION: If this file is not vector.go, it was generated
> +// automatically from vector.go - DO NOT EDIT in that case!
> +
>  package vector
>
>
> Index: src/pkg/exp/vector/stringvector_test.go
> ===================================================================
> --- a/src/pkg/exp/vector/stringvector_test.go
> +++ b/src/pkg/exp/vector/stringvector_test.go
> @@ -2,9 +2,11 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// CAUTION: If this file is not vector_test.go, it was generated
> +// automatically from vector_test.go - DO NOT EDIT in that case!
> +
>  package vector
>
> -
>  import "testing"
>
>
> Index: src/pkg/exp/vector/vector.go
> ===================================================================
> --- a/src/pkg/exp/vector/vector.go
> +++ b/src/pkg/exp/vector/vector.go
> @@ -2,6 +2,9 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// CAUTION: If this file is not vector.go, it was generated
> +// automatically from vector.go - DO NOT EDIT in that case!
> +
>  package vector
>
>
> Index: src/pkg/exp/vector/vector_test.go
> ===================================================================
> --- a/src/pkg/exp/vector/vector_test.go
> +++ b/src/pkg/exp/vector/vector_test.go
> @@ -2,9 +2,11 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// CAUTION: If this file is not vector_test.go, it was generated
> +// automatically from vector_test.go - DO NOT EDIT in that case!
> +
>  package vector
>
> -
>  import "testing"
>
>
>
>
>

[gri, 2009-12-22 23:14:12]

*** Submitted as http://code.google.com/p/go/source/detail?r=f08a013a4a90 ***

add comment (warning about generated files)

R=r
CC=golang-dev
http://codereview.appspot.com/180108