Issue 180099: code review 180099: cgo: interpret $CGOPKGDIR as absolute path if rooted

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 180099: code review 180099: cgo: interpret $CGOPKGDIR as absolute path if rooted (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by rsc

Modified:
15 years, 2 months ago

Reviewers:

CC:
dho, golang-dev

Visibility:
Public.

Description

cgo: interpret $CGOPKGDIR as absolute path if rooted

Patch Set 1 #

Patch Set 2 : code review 180099: cgo: interpret $CGOPKGDIR as absolute path if rooted #

Patch Set 3 : code review 180099: cgo: interpret $CGOPKGDIR as absolute path if rooted #

Patch Set 4 : code review 180099: cgo: interpret $CGOPKGDIR as absolute path if rooted #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -5 lines)			Patch
M	src/Make.pkg	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/cmd/cgo/main.go	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/cmd/cgo/out.go	View	1 2 3	3 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello dho (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 2 months ago (2009-12-21 15:46:23 UTC) #1

rsc

15 years, 2 months ago (2009-12-21 16:31:06 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=2ca6b9c73312 ***

cgo: interpret $CGOPKGDIR as absolute path if rooted

R=dho
CC=golang-dev
http://codereview.appspot.com/180099

Expand All Messages | Collapse All Messages