Issue 180092: gc: method expressions on concrete types

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 180092: gc: method expressions on concrete types (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by rsc

Modified:
15 years, 2 months ago

Reviewers:
ken3

CC:
ken2

Visibility:
Public.

Description

gc: method expressions on concrete types

Patch Set 1 #

Patch Set 2 : code review 180092: gc: method expressions on concrete types #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -20 lines)			Patch
M	src/cmd/gc/dcl.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/reflect.c	View	7 chunks	+9 lines, -9 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	5 chunks	+25 lines, -5 lines	0 comments	Download
M	test/method.go	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	test/method3.go	View	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=75168d77b51d *** gc: method expressions on concrete types R=ken2 http://codereview.appspot.com/180092

15 years, 2 months ago (2009-12-19 01:25:03 UTC) #1

ken3

15 years, 2 months ago (2009-12-19 23:52:30 UTC) #2

On 2009/12/19 01:25:03, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=75168d77b51d ***
> 
> gc: method expressions on concrete types
> 
> R=ken2
> http://codereview.appspot.com/180092

LGTM

Expand All Messages | Collapse All Messages