Issue 180085: code review 180085: report an error for illegal octal numbers instead of tr...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 180085: code review 180085: report an error for illegal octal numbers instead of tr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by gri

Modified:
15 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

report an error for illegal octal numbers instead of treating them as floats added more test cases some capitalization cleanups

Patch Set 1 #

Patch Set 2 : code review 180085: report an error for illegal octal numbers instead of tr... #

Patch Set 3 : code review 180085: report an error for illegal octal numbers instead of tr... #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -23 lines)			Patch
	M	src/pkg/go/scanner/scanner.go	View		5 chunks	+17 lines, -11 lines	0 comments	Download
	M	src/pkg/go/scanner/scanner_test.go	View		6 chunks	+78 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 2 months ago (2009-12-18 04:05:05 UTC) #1

gri

15 years, 2 months ago (2009-12-18 18:52:13 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5208f26a9da3 ***

report an error for illegal octal numbers instead of treating them as floats
added more test cases
some capitalization cleanups

R=rsc
CC=golang-dev
http://codereview.appspot.com/180085

Expand All Messages | Collapse All Messages