Issue 180074: code review 180074: Updated the XGB python script to generate semicolon-free

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 180074: code review 180074: Updated the XGB python script to generate semicolon-free (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by tor

Modified:
15 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Updated the XGB python script to generate semicolon-free source for xproto.go.

Patch Set 1 #

Patch Set 2 : code review 180074: Updated the XGB python script to generate semicolon-free #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -60 lines)			Patch
	M	src/pkg/xgb/go_client.py	View		15 chunks	+57 lines, -60 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

tor

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 3 months ago (2009-12-17 00:35:21 UTC) #1

tor

On 2009/12/17 01:09:24, rsc wrote: > looks good. > should xproto.go be here too? xproto.go ...

15 years, 3 months ago (2009-12-17 01:48:44 UTC) #3

rsc

> xproto.go hasn't changed, the earlier gofmt patches already > took away its semicolons. The ...

15 years, 2 months ago (2009-12-17 20:18:39 UTC) #4

rsc

15 years, 2 months ago (2009-12-17 20:19:44 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=dd9bae5c7eac ***

Updated the XGB python script to generate semicolon-free
source for xproto.go.

R=rsc
CC=golang-dev
http://codereview.appspot.com/180074

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages