code review 180030043: [release-branch.go1.4] runtime: fix atomic operations o...

[release-branch.go1.4] runtime: fix atomic operations on non-heap addresses

««« CL 179030043 / e4ab8f908aac
runtime: fix atomic operations on non-heap addresses
Race detector runtime does not tolerate operations on addresses
that was not previously declared with __tsan_map_shadow
(namely, data, bss and heap). The corresponding address
checks for atomic operations were removed in
https://codereview.appspot.com/111310044
Restore these checks.
It's tricker than just not calling into race runtime,
because it is the race runtime that makes the atomic
operations themselves (if we do not call into race runtime
we skip the atomic operation itself as well). So instead we call
__tsan_go_ignore_sync_start/end around the atomic operation.
This forces race runtime to skip all other processing
except than doing the atomic operation itself.
Fixes issue 9136.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/179030043

Committer: Russ Cox <rsc@golang.org>
»»»

[rsc, 2014-11-20 15:14:44]

Hello dvyukov (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2014-11-20 15:14:54]

*** Submitted as https://code.google.com/p/go/source/detail?r=0f20d1afae39 ***

[release-branch.go1.4] runtime: fix atomic operations on non-heap addresses

««« CL 179030043 / e4ab8f908aac
runtime: fix atomic operations on non-heap addresses
Race detector runtime does not tolerate operations on addresses
that was not previously declared with __tsan_map_shadow
(namely, data, bss and heap). The corresponding address
checks for atomic operations were removed in
https://codereview.appspot.com/111310044
Restore these checks.
It's tricker than just not calling into race runtime,
because it is the race runtime that makes the atomic
operations themselves (if we do not call into race runtime
we skip the atomic operation itself as well). So instead we call
__tsan_go_ignore_sync_start/end around the atomic operation.
This forces race runtime to skip all other processing
except than doing the atomic operation itself.
Fixes issue 9136.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/179030043

Committer: Russ Cox <rsc@golang.org>
»»»

TBR=dvyukov
CC=golang-codereviews
https://codereview.appspot.com/180030043

[dvyukov, 2014-11-20 15:24:40]

LGTM