Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(60)

Issue 179610043: code review 179610043: fmt: fix bug in scanning of hex strings

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by r
Modified:
9 years, 4 months ago
Reviewers:
CC:
golang-codereviews
Visibility:
Public.

Description

fmt: fix bug in scanning of hex strings Couldn't handle a hex string terminated by anything other than spaces. Easy to fix. Fixes issue 9124.

Patch Set 1 #

Patch Set 2 : diff -r ffe33f1f1f17bf7d9bd14d8a8931dc905a75d011 https://code.google.com/p/go #

Patch Set 3 : diff -r ffe33f1f1f17bf7d9bd14d8a8931dc905a75d011 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -13 lines) Patch
M src/fmt/scan.go View 1 chunk +19 lines, -13 lines 0 comments Download
M src/fmt/scan_test.go View 1 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 5
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 4 months ago (2014-12-01 04:22:33 UTC) #1
r
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 4 months ago (2014-12-01 04:24:57 UTC) #2
r
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 4 months ago (2014-12-01 04:25:25 UTC) #3
r
Updated with correct issue number.
9 years, 4 months ago (2014-12-01 04:25:43 UTC) #4
gobot
9 years, 4 months ago (2014-12-19 05:16:50 UTC) #5
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/179610043 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b