Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1023)

Issue 1792042: code review 1792042: tests/fixedbugs/bug243.go: instead of closing stdout, (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by Raj_
Modified:
13 years, 10 months ago
Reviewers:
CC:
rsc, iant, golang-dev
Visibility:
Public.

Description

tests/fixedbugs/bug243.go: instead of closing stdout, remove the print statements. This change is because of the port of gccgo to RTEMS. These tests use the GCC DejaGNU framework. In some cases, the tests need to be run on qemu where the status code cannot be sent back to DejaGNU, so it prints the exit status by putting a wrapper around the exit and abort calls. This testcase closes the stdout, and hence prohibits DejaGNU from knowing the status in such cases, and causes this test to be wrongly declared as a failure.

Patch Set 1 #

Patch Set 2 : code review 1792042: tests/fixedbugs/bug243.go: instead of closing stdout, #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M test/fixedbugs/bug243.go View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Raj_
Hello rsc, iant (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 10 months ago (2010-07-12 12:06:11 UTC) #1
rsc
LGTM that was weird code
13 years, 10 months ago (2010-07-12 20:16:55 UTC) #2
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=97f6a942d613 *** test/fixedbugs/bug243.go: instead of closing stdout, remove the print statements. This ...
13 years, 10 months ago (2010-07-12 20:17:37 UTC) #3
Raj_
13 years, 10 months ago (2010-07-12 21:25:33 UTC) #4
On Tue, Jul 13, 2010 at 1:46 AM, Russ Cox <rsc@golang.org> wrote:

> LGTM
>
> that was weird code
>

Sorry, the code I submitted had compiler errors. Didn't do a check
in haste.

And now I understand why you kept in the printlns, it was to prevent
the compiler from showing an error that the variable conn is unused.

Will submit a new CL.

Again, sorry.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b