Issue 179106: code review 179106: new comments for bytes.NewBuffer and NewBufferString.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 179106: code review 179106: new comments for bytes.NewBuffer and NewBufferString. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by r

Modified:
15 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

new comments for bytes.NewBuffer and NewBufferString. corrects a common misunderstanding about NewBuffer.

Patch Set 2 : code review 179106: new comments for bytes.NewBuffer and NewBufferString. #

Total comments: 1

Patch Set 3 : code review 179106: new comments for bytes.NewBuffer and NewBufferString. #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
	M	src/pkg/bytes/buffer.go	View	1 2	3 chunks	+12 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 2 months ago (2009-12-18 21:02:43 UTC) #1

rsc

LGTM http://codereview.appspot.com/179106/diff/3/1003 File src/pkg/bytes/buffer.go (right): http://codereview.appspot.com/179106/diff/3/1003#newcode224 src/pkg/bytes/buffer.go:224: // contents. Intended to prepare a Buffer to ...

15 years, 2 months ago (2009-12-18 21:31:58 UTC) #2

15 years, 2 months ago (2009-12-18 21:42:37 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ed15bdb4ab89 ***

new comments for bytes.NewBuffer and NewBufferString.
corrects a common misunderstanding about NewBuffer.

R=rsc
CC=golang-dev
http://codereview.appspot.com/179106

Expand All Messages | Collapse All Messages