Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1472)

Issue 179105: code review 179105: fix build, enable an exp/eval's assignment check (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 2 months ago by gri
Modified:
15 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

fix build, enable an exp/eval's assignment check now that the parser doesn't do this test anymore

Patch Set 1 #

Patch Set 2 : code review 179105: fix build, enable an exp/eval's assignment check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/pkg/exp/eval/stmt_test.go View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 3
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 2 months ago (2009-12-18 19:18:14 UTC) #1
rsc
LGTM On Fri, Dec 18, 2009 at 11:18, <gri@golang.org> wrote: > Reviewers: rsc, > > ...
15 years, 2 months ago (2009-12-18 19:21:00 UTC) #2
gri
15 years, 2 months ago (2009-12-18 19:21:16 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=62648b222a7c ***

fix build, enable an exp/eval's assignment check
now that the parser doesn't do this test anymore

R=rsc
CC=golang-dev
http://codereview.appspot.com/179105
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b