Issue 177890043: code review 177890043: [release-branch.go1.4] debug/goobj: move to cmd/interna...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 177890043: code review 177890043: [release-branch.go1.4] debug/goobj: move to cmd/interna... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by adg

Modified:
9 years, 6 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.4] debug/goobj: move to cmd/internal/goobj ««« CL 174250043 / c16349455e05 debug/goobj: move to cmd/internal/goobj debug/goobj is not ready to be published but it is needed for the various binary-reading commands. Move to cmd/internal/goobj. (The Go 1.3 release branch deleted it, but that's not an option anymore due to the command dependencies. The API is still not vetted nor terribly well designed.) LGTM=adg, dsymonds R=adg, dsymonds CC=golang-codereviews https://codereview.appspot.com/174250043 »»»

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
M	src/cmd/internal/goobj/read.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	src/cmd/internal/goobj/read_test.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	src/cmd/internal/objfile/goobj.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/link/auto.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/link/auto_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/link/dead.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/link/dead_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/link/layout.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/link/link_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/link/pclntab.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/link/pclntab_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/link/prog.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/link/runtime.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/link/scan.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 6 months ago (2014-11-17 01:55:36 UTC) #1

adg

9 years, 6 months ago (2014-11-17 01:56:45 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=8f706bcec837 ***

[release-branch.go1.4] debug/goobj: move to cmd/internal/goobj

««« CL 174250043 / c16349455e05
debug/goobj: move to cmd/internal/goobj

debug/goobj is not ready to be published but it is
needed for the various binary-reading commands.
Move to cmd/internal/goobj.

(The Go 1.3 release branch deleted it, but that's not
an option anymore due to the command dependencies.
The API is still not vetted nor terribly well designed.)

LGTM=adg, dsymonds
R=adg, dsymonds
CC=golang-codereviews
https://codereview.appspot.com/174250043
»»»

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/177890043

Expand All Messages | Collapse All Messages