Issue 177840043: code review 177840043: x/net/ipv6: update package documentation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 177840043: code review 177840043: x/net/ipv6: update package documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by mikio

Modified:
9 years, 6 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

x/net/ipv6: update package documentation

Patch Set 1 : diff -r e56a6fa23065dd8cede702d2ffb090c2c1999b28 https://code.google.com/p/go.net #

Total comments: 4

Patch Set 2 : diff -r c5a46024776ec35eb562fa9226968b9d543bb13a https://code.google.com/p/go.net #

Patch Set 3 : diff -r 355f337d9458e4b0a2a4546dd60d99b955c30feb https://code.google.com/p/go.net #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -33 lines)			Patch
M	ipv6/dgramopt_posix.go	View	1	4 chunks	+18 lines, -16 lines	0 comments	Download
M	ipv6/dgramopt_stub.go	View	1	2 chunks	+18 lines, -16 lines	0 comments	Download
M	ipv6/doc.go	View	1	2 chunks	+41 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.net

9 years, 6 months ago (2014-11-19 10:36:34 UTC) #1

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

9 years, 6 months ago (2014-11-19 10:38:19 UTC) #2

iant

LGTM after making suggested fixes. https://codereview.appspot.com/177840043/diff/120001/ipv6/doc.go File ipv6/doc.go (right): https://codereview.appspot.com/177840043/diff/120001/ipv6/doc.go#newcode195 ipv6/doc.go:195: // And then an ...

9 years, 6 months ago (2014-11-19 21:05:35 UTC) #3

mikio

ptal https://codereview.appspot.com/177840043/diff/120001/ipv6/doc.go File ipv6/doc.go (right): https://codereview.appspot.com/177840043/diff/120001/ipv6/doc.go#newcode195 ipv6/doc.go:195: // And then an application that uses PacketConn ...

9 years, 6 months ago (2014-11-20 05:38:53 UTC) #4

mikio

9 years, 6 months ago (2014-11-22 02:23:21 UTC) #6

*** Submitted as
https://code.google.com/p/go/source/detail?r=5dedbdc18162&repo=net ***

x/net/ipv6: update package documentation

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/177840043

Expand All Messages | Collapse All Messages