Issue 177770043: [dev.cc] code review 177770043: runtime: change set_sec to take int64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 177770043: [dev.cc] code review 177770043: runtime: change set_sec to take int64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by rsc

Modified:
10 years, 4 months ago

Reviewers:
austin

CC:
golang-codereviews

Visibility:
Public.

runtime: change set_sec to take int64 Fixes build. Tested that all these systems can make.bash.

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -22 lines)			Patch
M	src/runtime/defs_dragonfly_amd64.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime/defs_freebsd_386.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime/defs_freebsd_amd64.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime/defs_freebsd_arm.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime/defs_linux_386.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime/defs_linux_amd64.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime/defs_linux_arm.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime/defs_openbsd_386.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime/defs_openbsd_amd64.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime/os1_freebsd.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime/os1_linux.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime/os1_openbsd.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

rsc

Hello austin (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.cc branch ...

10 years, 4 months ago (2014-11-14 19:49:55 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=c6787f2301d2 *** [dev.cc] runtime: change set_sec to take int64 Fixes build. Tested ...

10 years, 4 months ago (2014-11-14 19:50:04 UTC) #2

Message was sent while issue was closed.

LGTM