code review 177700043: [release-branch.go1.4] go-tour/content/welcome.article:...

[release-branch.go1.4] go-tour/content/welcome.article: update restrictions of the playground.

««« CL 182390043 / 7d6c480ac226
go-tour/content/welcome.article: update restrictions of the playground.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/182390043
»»»

[minux, 2014-12-03 04:44:27]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go-tour

[minux, 2014-12-03 04:53:48]

I just diffed the default branch and the release-branch.go1.4, there is
still one
CL not merged: CL 177980043 (fix error highlighting when running locally).

I think we should merge it into 1.4 branch in preparation for running gotour
locally.

Btw, why is tour.golang.org still running the legacy version of go tour,
while
a few of the localized versions are already running the redesigned version.

[adg, 2014-12-03 05:08:59]

+Francesc Campoy Flores <campoy@google.com>​ can answer that. This CL LGTM.

On Wed Dec 03 2014 at 3:53:50 PM minux <minux@golang.org> wrote:

> I just diffed the default branch and the release-branch.go1.4, there is
> still one
> CL not merged: CL 177980043 (fix error highlighting when running locally).
>
> I think we should merge it into 1.4 branch in preparation for running
> gotour
> locally.
>
> Btw, why is tour.golang.org still running the legacy version of go tour,
> while
> a few of the localized versions are already running the redesigned version.
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[minux, 2014-12-03 05:13:49]

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=9df0ab75210b
***

[release-branch.go1.4] go-tour/content/welcome.article: update restrictions of
the playground.

««« CL 182390043 / 7d6c480ac226
go-tour/content/welcome.article: update restrictions of the playground.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/182390043
»»»

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://codereview.appspot.com/177700043

[campoy, 2014-12-03 17:14:14]

Sorry I forgot to submit the CL, no it's done

On Tue, Dec 2, 2014 at 9:08 PM, Andrew Gerrand <adg@golang.org> wrote:

> +Francesc Campoy Flores <campoy@google.com>​ can answer that. This CL
> LGTM.
>
> On Wed Dec 03 2014 at 3:53:50 PM minux <minux@golang.org> wrote:
>
>> I just diffed the default branch and the release-branch.go1.4, there is
>> still one
>> CL not merged: CL 177980043 (fix error highlighting when running locally).
>>
>> I think we should merge it into 1.4 branch in preparation for running
>> gotour
>> locally.
>>
>> Btw, why is tour.golang.org still running the legacy version of go tour,
>> while
>> a few of the localized versions are already running the redesigned
>> version.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>