Issue 177530043: code review 177530043: x/net/ipv6: add Header, ParseHeader

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 177530043: code review 177530043: x/net/ipv6: add Header, ParseHeader (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by mikio

Modified:
10 years, 3 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

x/net/ipv6: add Header, ParseHeader This CL adds Header type and ParseHeader function for convenience in parsing ICMP error messages such as destination unreachable, packet too big, time exceeded and parameter problem.

Patch Set 1 : diff -r 896befd28fdd147b9f3571a4916693d95a1eaa89 https://code.google.com/p/go.net #

Patch Set 2 : diff -r 896befd28fdd147b9f3571a4916693d95a1eaa89 https://code.google.com/p/go.net #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -0 lines)			Patch
	A	ipv6/header.go	View		1 chunk	+55 lines, -0 lines	0 comments	Download
	A	ipv6/header_test.go	View		1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

10 years, 3 months ago (2014-11-28 08:25:39 UTC) #1

mikio

10 years, 3 months ago (2014-11-29 01:13:04 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=232b827c46d5&repo=net ***

x/net/ipv6: add Header, ParseHeader

This CL adds Header type and ParseHeader function for convenience
in parsing ICMP error messages such as destination unreachable,
packet too big, time exceeded and parameter problem.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/177530043

Expand All Messages | Collapse All Messages