Issue 1774044: code review 1774044: pem: print \n after 1 header line too

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1774044: code review 1774044: pem: print \n after 1 header line too (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by rsc

Modified:
14 years, 8 months ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

Description

pem: print \n after 1 header line too rearrange to make reason for if clear. Fixes issue 911.

Patch Set 1 #

Patch Set 2 : code review 1774044: pem: print \n after 1 header line too #

Patch Set 3 : code review 1774044: pem: print \n after 1 header line too #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	src/pkg/encoding/pem/pem.go	View		1 chunk	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello agl1 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-07-12 23:39:22 UTC) #1

rsc

14 years, 8 months ago (2010-07-12 23:48:51 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5296aa446e1e ***

pem: print \n after 1 header line too
rearrange to make reason for if clear.

Fixes issue 911.

R=agl1
CC=golang-dev
http://codereview.appspot.com/1774044

Expand All Messages | Collapse All Messages