Issue 177170043: [dev.cc] code review 177170043: runtime: convert netbsd/386 port to Go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 177170043: [dev.cc] code review 177170043: runtime: convert netbsd/386 port to Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by jsing

Modified:
10 years, 4 months ago

Reviewers:
minux

CC:
rsc, minux, golang-codereviews

Visibility:
Public.

Description

runtime: convert netbsd/386 port to Go

Patch Set 1 #

Patch Set 2 : diff -r ccea2c6008f0a4d6a1571132011477741c63a96c https://go.googlecode.com/hg #

Patch Set 3 : diff -r ccea2c6008f0a4d6a1571132011477741c63a96c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ccea2c6008f0a4d6a1571132011477741c63a96c https://go.googlecode.com/hg/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -32 lines)			Patch
M	src/runtime/defs1_netbsd_386.go	View	1	3 chunks	+17 lines, -5 lines	0 comments	Download
M	src/runtime/os1_netbsd_386.go	View	1	1 chunk	+10 lines, -11 lines	0 comments	Download
M	src/runtime/signal_netbsd_386.go	View	1	1 chunk	+31 lines, -16 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jsing

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.cc branch ...

10 years, 4 months ago (2014-11-22 10:12:28 UTC) #1

jsing

10 years, 4 months ago (2014-11-22 11:09:24 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=cba220e28139 ***

[dev.cc] runtime: convert netbsd/386 port to Go

LGTM=minux
R=rsc, minux
CC=golang-codereviews
https://codereview.appspot.com/177170043

Expand All Messages | Collapse All Messages