Issue 1771043: code review 1771043: container/vector: remove Iter() from interface

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1771043: code review 1771043: container/vector: remove Iter() from interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by gri

Modified:
13 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

container/vector: remove Iter() from interface (Iter() is almost never the right mechanism to call. Per discussion with rsc.)

Patch Set 1 #

Patch Set 2 : code review 1771043: container/vector: remove Iter() from interface #

Patch Set 3 : code review 1771043: container/vector: remove Iter() from interface #

Patch Set 4 : code review 1771043: container/vector: remove Iter() from interface #

Patch Set 5 : code review 1771043: container/vector: remove Iter() from interface #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -197 lines)			Patch
M	src/pkg/container/vector/Makefile	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/pkg/container/vector/intvector.go	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/pkg/container/vector/intvector_test.go	View	1 chunk	+0 lines, -47 lines	0 comments	Download
M	src/pkg/container/vector/stringvector.go	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/pkg/container/vector/stringvector_test.go	View	1 chunk	+0 lines, -47 lines	0 comments	Download
M	src/pkg/container/vector/vector.go	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/pkg/container/vector/vector_test.go	View	1 chunk	+0 lines, -47 lines	0 comments	Download
M	src/pkg/nntp/nntp.go	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 10 months ago (2010-07-09 22:36:12 UTC) #1

gri

13 years, 10 months ago (2010-07-12 20:51:49 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=6e41dc758bf7 ***

container/vector: remove Iter() from interface
(Iter() is almost never the right mechanism to call.
Per discussion with rsc.)

R=rsc
CC=golang-dev
http://codereview.appspot.com/1771043

Expand All Messages | Collapse All Messages