Issue 177090043: [dev.cc] code review 177090043: runtime: convert remaining windows C code to Go

Issue 177090043: [dev.cc] code review 177090043: runtime: convert remaining windows C code to Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by brainman

Modified:
10 years, 4 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

runtime: convert remaining windows C code to Go

Patch Set 2 : diff -r d4db9ec3b0d32dbbd48590aeda679d74576284da https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d4db9ec3b0d32dbbd48590aeda679d74576284da https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 4 : diff -r d4db9ec3b0d32dbbd48590aeda679d74576284da https://go.googlecode.com/hg/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+585 lines, -716 lines)			Patch
M	src/runtime/netpoll_windows.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime/os1_windows.go	View	1 2 3	1 chunk	+408 lines, -480 lines	0 comments	Download
M	src/runtime/os1_windows_386.go	View	1	2 chunks	+73 lines, -83 lines	0 comments	Download
M	src/runtime/os1_windows_amd64.go	View	1	2 chunks	+84 lines, -97 lines	0 comments	Download
M	src/runtime/os2_windows.go	View	1	1 chunk	+11 lines, -28 lines	0 comments	Download
M	src/runtime/os_windows.go	View	1	1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/runtime/stubs2.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime/syscall_windows.go	View	1	3 chunks	+7 lines, -11 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.cc branch ...

10 years, 4 months ago (2014-11-19 23:33:48 UTC) #1

brainman

This CL replaces CLs 175860043 and 179850043. It includes latest changes - everything to have ...

10 years, 4 months ago (2014-11-19 23:34:48 UTC) #2

rsc

LGTM https://codereview.appspot.com/177090043/diff/40001/src/runtime/os1_windows.go File src/runtime/os1_windows.go (right): https://codereview.appspot.com/177090043/diff/40001/src/runtime/os1_windows.go#newcode77 src/runtime/os1_windows.go:77: // TODO(brinman): not sure how to translate "#pragma ...

10 years, 4 months ago (2014-11-20 00:25:48 UTC) #3

brainman

10 years, 4 months ago (2014-11-20 01:24:17 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=4e8f29def76a ***

[dev.cc] runtime: convert remaining windows C code to Go

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/177090043

https://codereview.appspot.com/177090043/diff/40001/src/runtime/os1_windows.go
File src/runtime/os1_windows.go (right):

https://codereview.appspot.com/177090043/diff/40001/src/runtime/os1_windows.g...
src/runtime/os1_windows.go:77: // TODO(brinman): not sure how to translate
"#pragma dataflag NOPTR"
On 2014/11/20 00:25:47, rsc wrote:
> You don't need it. The Go compiler knows there's no pointer here.

Removed TODO.

https://codereview.appspot.com/177090043/diff/40001/src/runtime/os1_windows.g...
src/runtime/os1_windows.go:471: // TODO(brinman): not sure how to translate
"#pragma dataflag NOPTR"
On 2014/11/20 00:25:47, rsc wrote:
> You don't need it. The Go compiler knows there are no pointers in a uintptr.

Removed TODO.

https://codereview.appspot.com/177090043/diff/40001/src/runtime/os1_windows.g...
src/runtime/os1_windows.go:545: // TODO(brinman): not sure how to translate
"#pragma dataflag NOPTR"
On 2014/11/20 00:25:47, rsc wrote:
> You don't need it. The Go compiler knows there are no pointers here.

Removed TODO.

Expand All Messages | Collapse All Messages