Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4499)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 176910043: code review 176910043: [release-branch.go1.4] remove cmd/link (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by adg
Modified:
9 years, 5 months ago
Reviewers:
gobot, dsymonds, minux
CC:
rsc, dsymonds, minux, golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.4] remove cmd/link

Patch Set 1 #

Patch Set 2 : diff -r 8f706bcec837df71b410175bf9a209be22ca3ebc https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5270 lines) Patch
R src/cmd/link/auto.go View 1 chunk +0 lines, -117 lines 0 comments Download
R src/cmd/link/auto_test.go View 1 chunk +0 lines, -72 lines 0 comments Download
R src/cmd/link/dead.go View 1 chunk +0 lines, -74 lines 0 comments Download
R src/cmd/link/dead_test.go View 1 chunk +0 lines, -97 lines 0 comments Download
R src/cmd/link/debug.go View 1 chunk +0 lines, -11 lines 0 comments Download
R src/cmd/link/hex_test.go View 1 chunk +0 lines, -74 lines 0 comments Download
R src/cmd/link/layout.go View 1 chunk +0 lines, -180 lines 0 comments Download
R src/cmd/link/layout_test.go View 1 chunk +0 lines, -45 lines 0 comments Download
R src/cmd/link/link_test.go View 1 chunk +0 lines, -35 lines 0 comments Download
R src/cmd/link/load.go View 1 chunk +0 lines, -116 lines 0 comments Download
R src/cmd/link/macho.go View 1 chunk +0 lines, -380 lines 0 comments Download
R src/cmd/link/macho_test.go View 1 chunk +0 lines, -407 lines 0 comments Download
R src/cmd/link/main.go View 1 chunk +0 lines, -9 lines 0 comments Download
R src/cmd/link/pclntab.go View 1 chunk +0 lines, -479 lines 0 comments Download
R src/cmd/link/pclntab_test.go View 1 chunk +0 lines, -340 lines 0 comments Download
R src/cmd/link/prog.go View 1 chunk +0 lines, -220 lines 0 comments Download
R src/cmd/link/prog_test.go View 1 chunk +0 lines, -163 lines 0 comments Download
R src/cmd/link/runtime.go View 1 chunk +0 lines, -28 lines 0 comments Download
R src/cmd/link/scan.go View 1 chunk +0 lines, -187 lines 0 comments Download
R src/cmd/link/testdata/Makefile View 1 chunk +0 lines, -15 lines 0 comments Download
R src/cmd/link/testdata/autosection.6 View Binary file 0 comments Download
R src/cmd/link/testdata/autosection.s View 1 chunk +0 lines, -60 lines 0 comments Download
R src/cmd/link/testdata/autoweak.6 View Binary file 0 comments Download
R src/cmd/link/testdata/autoweak.s View 1 chunk +0 lines, -30 lines 0 comments Download
R src/cmd/link/testdata/dead.6 View Binary file 0 comments Download
R src/cmd/link/testdata/dead.s View 1 chunk +0 lines, -48 lines 0 comments Download
R src/cmd/link/testdata/genpcln.go View 1 chunk +0 lines, -112 lines 0 comments Download
R src/cmd/link/testdata/hello.6 View Binary file 0 comments Download
R src/cmd/link/testdata/hello.s View 1 chunk +0 lines, -15 lines 0 comments Download
R src/cmd/link/testdata/layout.6 View Binary file 0 comments Download
R src/cmd/link/testdata/layout.s View 1 chunk +0 lines, -29 lines 0 comments Download
R src/cmd/link/testdata/link.hello.darwin.amd64 View 1 chunk +0 lines, -54 lines 0 comments Download
R src/cmd/link/testdata/macho.amd64.exit9 View 1 chunk +0 lines, -24 lines 0 comments Download
R src/cmd/link/testdata/macho.amd64.hello View 1 chunk +0 lines, -39 lines 0 comments Download
R src/cmd/link/testdata/macho.amd64.helloro View 1 chunk +0 lines, -34 lines 0 comments Download
R src/cmd/link/testdata/pclntab.6 View Binary file 0 comments Download
R src/cmd/link/testdata/pclntab.s View 1 chunk +0 lines, -1751 lines 0 comments Download
R src/cmd/link/util.go View 1 chunk +0 lines, -11 lines 0 comments Download
R src/cmd/link/write.go View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 5 months ago (2014-11-17 02:37:32 UTC) #1
dsymonds
LGTM
9 years, 5 months ago (2014-11-17 02:44:51 UTC) #2
minux
LGTM.
9 years, 5 months ago (2014-11-17 02:45:03 UTC) #3
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=0e2181d86f0b *** [release-branch.go1.4] remove cmd/link LGTM=dsymonds, minux R=rsc, dsymonds, minux CC=golang-codereviews https://codereview.appspot.com/176910043
9 years, 5 months ago (2014-11-17 02:47:01 UTC) #4
gobot
9 years, 5 months ago (2014-11-17 02:49:26 UTC) #5
Message was sent while issue was closed. 
This CL appears to have broken the nacl-amd64p32 builder.
See http://build.golang.org/log/dc6b4d2e140f4f4eb5309380604e72e8856e2079
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b