Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(771)

Issue 176290043: code review 176290043: go/build: build $GOOS_test.go always (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by rsc
Modified:
9 years, 4 months ago
Reviewers:
r
CC:
r, golang-codereviews
Visibility:
Public.

Description

go/build: build $GOOS_test.go always We decided to build $GOOS.go always but forgot to test $GOOS_test.go. Fixes issue 9159.

Patch Set 1 #

Patch Set 2 : diff -r 95f5614b464869b8c1dfbc63fe25a877709e8aa2 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 95f5614b464869b8c1dfbc63fe25a877709e8aa2 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 95f5614b464869b8c1dfbc63fe25a877709e8aa2 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/go/build/build.go View 1 1 chunk +5 lines, -3 lines 0 comments Download
M src/go/build/build_test.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 4 months ago (2014-11-25 01:12:31 UTC) #1
r
LGTM
9 years, 4 months ago (2014-11-25 01:17:09 UTC) #2
rsc
9 years, 4 months ago (2014-11-25 01:18:50 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=8025b7d1e6c9 ***

go/build: build $GOOS_test.go always

We decided to build $GOOS.go always
but forgot to test $GOOS_test.go.

Fixes issue 9159.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/176290043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b