code review 176056: Abort doing a clean when $GOROOT isn't set.

Abort doing a clean when $GOROOT isn't set.

Doing rm -rf /pkg/.. blindly isn't nice.  It could have
unintended consequences.

Secondly set bash to abort on (unexpected) errors.

[cw, 2009-12-11 22:46:30]

Hello dho, rsc, r (cc: cw),

I'd like you to review the following change.

[dho, 2009-12-11 22:56:10]

LGTM otherwise

http://codereview.appspot.com/176056/diff/3/4
File src/clean.bash (right):

http://codereview.appspot.com/176056/diff/3/4#newcode12
src/clean.bash:12: 
Extra space at the end seems unnecessary

[rsc, 2009-12-11 22:58:20]

http://codereview.appspot.com/176056/diff/3/4
File src/clean.bash (right):

http://codereview.appspot.com/176056/diff/3/4#newcode9
src/clean.bash:9: echo "\$GOROOT not set"
use single quotes instead?

[cw, 2009-12-11 23:06:13]

Hello dho, rsc (cc: golang-dev@googlegroups.com),

I'd like you to review the following change.

[rsc, 2009-12-11 23:10:02]

LGTM

thanks

[rsc, 2009-12-13 20:27:22]

*** Submitted as http://code.google.com/p/go/source/detail?r=06959cf5ba1b ***

clean.bash: stop if $GOROOT is not set

Doing rm -rf /pkg/.. blindly isn't nice.  It could have
unintended consequences.

Secondly set bash to abort on (unexpected) errors.

R=dho, rsc
CC=golang-dev
http://codereview.appspot.com/176056

Committer: Russ Cox <rsc@golang.org>