Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2703)

Issue 175780043: [dev.power64] code review 175780043: 6g,9g: formatters for Prog and Addr details (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by austin
Modified:
9 years, 5 months ago
Reviewers:
gobot, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

6g,9g: formatters for Prog and Addr details The pretty printers for these make it hard to understand what's actually in the fields of these structures. These "ugly printers" show exactly what's in each field, which can be useful for understanding and debugging code.

Patch Set 1 #

Patch Set 2 : diff -r 6d7a9c796f8843ef5fdafdfe41de281ce8fe0ef9 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -1 line) Patch
M src/cmd/5l/5.out.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/6l/6.out.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/8l/8.out.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/9l/9.out.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/dist/buildgc.c View 1 chunk +3 lines, -1 line 0 comments Download
M src/liblink/list6.c View 2 chunks +38 lines, -0 lines 0 comments Download
M src/liblink/list9.c View 2 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 4
austin
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 branch ...
9 years, 5 months ago (2014-11-14 18:46:13 UTC) #1
rsc
LGTM
9 years, 5 months ago (2014-11-14 18:53:57 UTC) #2
austin
*** Submitted as https://code.google.com/p/go/source/detail?r=776e2cb1a1f3 *** [dev.power64] 6g,9g: formatters for Prog and Addr details The pretty ...
9 years, 5 months ago (2014-11-14 18:58:35 UTC) #3
gobot
9 years, 5 months ago (2014-11-14 18:59:02 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the solaris-amd64-smartos builder.
See http://build.golang.org/log/5a2a6633f8b0cbbc27e687890bab6092cf36f08a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b