Issue 175770043: code review 175770043: go/callgraph/rta: rename from go/rta

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 175770043: code review 175770043: go/callgraph/rta: rename from go/rta (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by adonovan

Modified:
9 years, 6 months ago

Reviewers:
Sameer Ajmani

CC:
Sameer Ajmani, golang-codereviews, gri

Visibility:
Public.

Description

go/callgraph/rta: rename from go/rta

Patch Set 1 #

Patch Set 2 : diff -r 3f136f11ec7a7e9c44b5bdccfaa90a2e0fb837bf https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 3f136f11ec7a7e9c44b5bdccfaa90a2e0fb837bf https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 3f136f11ec7a7e9c44b5bdccfaa90a2e0fb837bf https://code.google.com/p/go.tools #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-2 lines, --2 lines)			Patch
M	cmd/callgraph/main.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	go/callgraph/rta/rta.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	go/callgraph/rta/rta_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	go/callgraph/rta/testdata/func.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	go/callgraph/rta/testdata/iface.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	go/callgraph/rta/testdata/rtype.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello sameer@golang.org (cc: golang-codereviews@googlegroups.com, gri@golang.org), I'd like you to review this change to https://code.google.com/p/go.tools

9 years, 6 months ago (2014-11-14 15:54:20 UTC) #1

Sameer Ajmani

On 2014/11/14 15:54:20, adonovan wrote: > Hello mailto:sameer@golang.org (cc: mailto:golang-codereviews@googlegroups.com, > mailto:gri@golang.org), > > I'd ...

9 years, 6 months ago (2014-11-14 15:59:50 UTC) #2

adonovan

9 years, 6 months ago (2014-11-14 16:02:48 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=7a206220eb24&repo=tools ***

go/callgraph/rta: rename from go/rta

LGTM=sameer
R=sameer
CC=golang-codereviews, gri
https://codereview.appspot.com/175770043

Expand All Messages | Collapse All Messages