Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(741)

Issue 175430043: [dev.cc] code review 175430043: liblink: fix Solaris build some more (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by austin
Modified:
10 years, 3 months ago
Reviewers:
aram, minux, dave
CC:
rsc, minux, aram, golang-codereviews
Visibility:
Public.

Description

liblink: fix Solaris build some more a->name and a->class are char, so Solaris doesn't like using them as array indexes. (This same problem was fixed for amd64 in CL 169630043.)

Patch Set 1 #

Patch Set 2 : diff -r 176ee4e4579a2a51491d79e41ed027d04d45db39 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/liblink/list9.c View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7
austin
Hello rsc, minux (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.cc ...
10 years, 3 months ago (2014-11-20 16:35:49 UTC) #1
aram
LGTM
10 years, 3 months ago (2014-11-20 16:38:49 UTC) #2
minux
i'm wondering if we should either disable the char-subscript warning in cmd/dist or always enable ...
10 years, 3 months ago (2014-11-20 18:34:29 UTC) #3
austin
This won't matter once it's all in Go. On Thu, Nov 20, 2014 at 1:34 ...
10 years, 3 months ago (2014-11-20 18:46:42 UTC) #4
minux
LGTM.
10 years, 3 months ago (2014-11-20 18:51:31 UTC) #5
austin
*** Submitted as https://code.google.com/p/go/source/detail?r=0f9a277c13da *** [dev.cc] liblink: fix Solaris build some more a->name and a->class ...
10 years, 3 months ago (2014-11-20 19:28:56 UTC) #6
dave_cheney.net
10 years, 3 months ago (2014-11-20 20:27:42 UTC) #7
LGTM.

On Fri, Nov 21, 2014 at 6:28 AM, austin via golang-codereviews
<golang-codereviews@googlegroups.com> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=0f9a277c13da ***
>
> [dev.cc] liblink: fix Solaris build some more
>
> a->name and a->class are char, so Solaris doesn't like using
> them as array indexes.  (This same problem was fixed for amd64
> in CL 169630043.)
>
> LGTM=aram, minux
> R=rsc, minux, aram
> CC=golang-codereviews
> https://codereview.appspot.com/175430043
>
>
> https://codereview.appspot.com/175430043/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b