Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

Issue 175070043: [dev.cc] code review 175070043: liblink: fix warnings on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by 0intro
Modified:
10 years, 3 months ago
Reviewers:
austin, bradfitz
CC:
rsc, bradfitz, austin, golang-codereviews
Visibility:
Public.

Description

liblink: fix warnings on Plan 9 warning: src/liblink/asm9.c:501 set and not used: bflag warning: src/liblink/list9.c:259 format mismatch .5lux INT, arg 4 warning: src/liblink/list9.c:261 format mismatch .5lux INT, arg 3 warning: src/liblink/list9.c:319 more arguments than format VLONG warning: src/liblink/obj9.c:222 set and not used: autoffset

Patch Set 1 #

Patch Set 2 : diff -r c6787f2301d2cb7a5a49ad0406a1b7aae9a6f958 https://code.google.com/p/go #

Patch Set 3 : diff -r c6787f2301d2cb7a5a49ad0406a1b7aae9a6f958 https://code.google.com/p/go #

Patch Set 4 : diff -r c6787f2301d2cb7a5a49ad0406a1b7aae9a6f958 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/liblink/asm9.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/liblink/list9.c View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/liblink/obj9.c View 1 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 6
0intro
Hello rsc (cc: austin, golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.cc ...
10 years, 3 months ago (2014-11-14 21:30:35 UTC) #1
bradfitz
LGTM On Fri, Nov 14, 2014 at 1:30 PM, <0intro@gmail.com> wrote: > Reviewers: rsc, > ...
10 years, 3 months ago (2014-11-14 21:31:29 UTC) #2
austin
LGTM Possibly this should have been done on dev.power64, but hopefully the difference won't matter ...
10 years, 3 months ago (2014-11-14 21:40:57 UTC) #3
0intro
> Possibly this should have been done on dev.power64, but hopefully the > difference won't ...
10 years, 3 months ago (2014-11-14 21:49:42 UTC) #4
0intro
*** Submitted as https://code.google.com/p/go/source/detail?r=c86fc52684d6 *** [dev.cc] liblink: fix warnings on Plan 9 warning: src/liblink/asm9.c:501 set ...
10 years, 3 months ago (2014-11-14 21:58:07 UTC) #5
austin
10 years, 3 months ago (2014-11-14 22:00:27 UTC) #6
I'm still working out some stuff on dev.power64 that I'd rather get stable
there before I also have to deal with dev.cc, but once I'm done with that
(hopefully some time next week), we'll probably do a final merge of
dev.power64 into dev.cc and close dev.power64.

On Fri, Nov 14, 2014 at 4:49 PM, David du Colombier <0intro@gmail.com>
wrote:

> > Possibly this should have been done on dev.power64, but hopefully the
> > difference won't matter much longer.
>
> Is the dev.power64 branch still alive since it was merged with dev.cc?
>
> --
> David du Colombier
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b