Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1740)

Issue 175048: code review 175048: fix printer test for new syntax (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by gri
Modified:
15 years, 3 months ago
Reviewers:
rsc
Visibility:
Public.

Description

fix printer test for new syntax

Patch Set 1 #

Patch Set 2 : code review 175048: fix printer test for new syntax #

Patch Set 3 : code review 175048: fix printer test for new syntax #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -105 lines) Patch
M src/pkg/go/printer/nodes.go View 3 chunks +19 lines, -0 lines 0 comments Download
M src/pkg/go/printer/printer_test.go View 3 chunks +11 lines, -2 lines 0 comments Download
M src/pkg/go/printer/testdata/declarations.golden View 1 4 chunks +75 lines, -1 line 0 comments Download
M src/pkg/go/printer/testdata/declarations.input View 1 5 chunks +75 lines, -4 lines 0 comments Download
M src/pkg/go/printer/testdata/expressions.golden View 3 chunks +27 lines, -27 lines 0 comments Download
M src/pkg/go/printer/testdata/expressions.input View 4 chunks +35 lines, -35 lines 0 comments Download
M src/pkg/go/printer/testdata/expressions.raw View 3 chunks +27 lines, -27 lines 0 comments Download
M src/pkg/go/printer/testdata/linebreaks.golden View 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/go/printer/testdata/linebreaks.input View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 6
gri
Hello rsc, I'd like you to review the following change.
15 years, 3 months ago (2009-12-11 02:22:05 UTC) #1
rsc
LGTM On Thu, Dec 10, 2009 at 18:22, <gri@golang.org> wrote: > http://codereview.appspot.com/175048
15 years, 3 months ago (2009-12-11 02:27:21 UTC) #2
rsc
LGTM
15 years, 3 months ago (2009-12-11 18:27:41 UTC) #3
gri
PTAL The declarations files have a patch with extra tests. The rewritten code is not ...
15 years, 3 months ago (2009-12-11 23:11:59 UTC) #4
rsc
LGTM
15 years, 3 months ago (2009-12-11 23:16:27 UTC) #5
gri
15 years, 3 months ago (2009-12-11 23:31:08 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=4bde7eb31ad9 ***

fix printer test for new syntax

R=rsc
http://codereview.appspot.com/175048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b