code review 174740043: go.tools/dashboard/builder: rewrite sub-repo paths befo...

go.tools/dashboard/builder: rewrite sub-repo paths before 'go get' and 'go test'

The dashboard still uses the old "code.google.com/p/go.*" import paths.
Rewrite them to the new "golang.org/x/*" before running 'go get' and 'go test'.

Update issue 9079.

[adg, 2014-11-09 23:30:26]

Hello rsc, bradfitz (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[adg, 2014-11-09 23:31:34]

I tested this just now with the builder named darwin-amd64-adg. All "ok".


On Mon Nov 10 2014 at 10:30:29 AM <adg@golang.org> wrote:

> Reviewers: rsc, bradfitz,
>
> Message:
> Hello rsc, bradfitz (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> go.tools/dashboard/builder: rewrite sub-repo paths before 'go get' and
> 'go test'
>
> The dashboard still uses the old "code.google.com/p/go.*" import paths.
> Rewrite them to the new "golang.org/x/*" before running 'go get' and 'go
> test'.
>
> Update issue 9079.
>
> Please review this at https://codereview.appspot.com/174740043/
>
> Affected files (+3, -0 lines):
>    M dashboard/builder/main.go
>
>
> Index: dashboard/builder/main.go
> ===================================================================
> --- a/dashboard/builder/main.go
> +++ b/dashboard/builder/main.go
> @@ -581,6 +581,9 @@
>                 env[i] = p + filepath.Join(goRoot, "bin") + sep +
> filepath.Join(goPath, "bin") + sep + e[len(p):]
>         }
>
> +       // HACK: check out to new sub-repo location instead of old
> location.
> +       pkg = strings.Replace(pkg, "code.google.com/p/go.", "golang.org/x/",
> 1)
> +
>         // fetch package and dependencies
>         var outbuf bytes.Buffer
>         err := run(exec.Command(goTool, "get", "-d", pkg+"/..."),
> runEnv(env),
> allOutput(&outbuf), runDir(goPath))
>
>
>

[rsc, 2014-11-09 23:39:21]

LGTM for now

[adg, 2014-11-09 23:42:44]

*** Submitted as
https://code.google.com/p/go/source/detail?r=75944e2e3a63&repo=tools ***

go.tools/dashboard/builder: rewrite sub-repo paths before 'go get' and 'go test'

The dashboard still uses the old "code.google.com/p/go.*" import paths.
Rewrite them to the new "golang.org/x/*" before running 'go get' and 'go test'.

Update issue 9079.

LGTM=rsc
R=rsc, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/174740043