code review 174250043: debug/goobj: move to cmd/internal/goobj

debug/goobj: move to cmd/internal/goobj

debug/goobj is not ready to be published but it is
needed for the various binary-reading commands.
Move to cmd/internal/goobj.

(The Go 1.3 release branch deleted it, but that's not
an option anymore due to the command dependencies.
The API is still not vetted nor terribly well designed.)

[rsc, 2014-11-17 01:44:07]

Hello adg (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[adg1, 2014-11-17 01:46:22]

What about the other commands that use this? I don't see them in this CL

[adg1, 2014-11-17 01:46:22]

What about the other commands that use this? I don't see them in this CL

[rsc, 2014-11-17 01:49:02]

I think I got it all. Things like cmd/addr2line use it only via
cmd/internal/objfile, not directly.

[adg1, 2014-11-17 01:49:57]

LGTM

On Mon Nov 17 2014 at 12:49:03 PM Russ Cox <rsc@golang.org> wrote:

> I think I got it all. Things like cmd/addr2line use it only via
> cmd/internal/objfile, not directly.
>
>

[dsymonds, 2014-11-17 01:50:30]

LGTM


On 2014/11/17 01:46:22, adg1 wrote:
> What about the other commands that use this? I don't see them in this CL

cmd/link is the only command that explicitly imports debug/goobj.

[rsc, 2014-11-17 01:52:51]

*** Submitted as https://code.google.com/p/go/source/detail?r=c16349455e05 ***

debug/goobj: move to cmd/internal/goobj

debug/goobj is not ready to be published but it is
needed for the various binary-reading commands.
Move to cmd/internal/goobj.

(The Go 1.3 release branch deleted it, but that's not
an option anymore due to the command dependencies.
The API is still not vetted nor terribly well designed.)

LGTM=adg, dsymonds
R=adg, dsymonds
CC=golang-codereviews
https://codereview.appspot.com/174250043