Issue 174042: code review 174042: make test/ken safe for optional semis

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 174042: code review 174042: make test/ken safe for optional semis (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by gri

Modified:
15 years, 3 months ago

Reviewers:
ken3, ken2, rsc

Visibility:
Public.

Description

make test/ken safe for optional semis

Patch Set 1 #

Patch Set 2 : code review 174042: make test/ken safe for optional semis #

Patch Set 3 : code review 174042: make test/ken safe for optional semis #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -394 lines)			Patch
M	test/ken/array.go	View	12 chunks	+12 lines, -24 lines	0 comments	Download
M	test/ken/chan.go	View	17 chunks	+24 lines, -46 lines	0 comments	Download
M	test/ken/chan1.go	View	4 chunks	+4 lines, -7 lines	0 comments	Download
M	test/ken/complit.go	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	test/ken/divconst.go	View	23 chunks	+26 lines, -52 lines	0 comments	Download
M	test/ken/divmod.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/ken/embed.go	View	9 chunks	+17 lines, -43 lines	0 comments	Download
M	test/ken/for.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/ken/interbasic.go	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	test/ken/interfun.go	View	1 chunk	+6 lines, -14 lines	0 comments	Download
M	test/ken/intervar.go	View	1 chunk	+8 lines, -19 lines	0 comments	Download
M	test/ken/label.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/ken/litfun.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/ken/mfunc.go	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	test/ken/modconst.go	View	23 chunks	+26 lines, -52 lines	0 comments	Download
M	test/ken/ptrfun.go	View	2 chunks	+4 lines, -10 lines	0 comments	Download
M	test/ken/ptrvar.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/ken/range.go	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	test/ken/rob1.go	View	2 chunks	+10 lines, -25 lines	0 comments	Download
M	test/ken/rob2.go	View	10 chunks	+12 lines, -24 lines	0 comments	Download
M	test/ken/shift.go	View	4 chunks	+5 lines, -10 lines	0 comments	Download
M	test/ken/simparray.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/ken/simpbool.go	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	test/ken/simpconv.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/ken/simpfun.go	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	test/ken/simpprint.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/ken/simpswitch.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/ken/simpvar.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/ken/slicearray.go	View	4 chunks	+4 lines, -8 lines	0 comments	Download
M	test/ken/sliceslice.go	View	4 chunks	+4 lines, -8 lines	0 comments	Download
M	test/ken/string.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/ken/strvar.go	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc, ken2, I'd like you to review the following change.

15 years, 3 months ago (2009-12-10 19:41:13 UTC) #1

ken3

On 2009/12/10 19:41:13, gri wrote: > Hello rsc, ken2, > > I'd like you to ...

15 years, 3 months ago (2009-12-10 20:13:31 UTC) #2

gri

15 years, 3 months ago (2009-12-10 20:53:28 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5f2608a4504f ***

make test/ken safe for optional semis

R=rsc, ken2, ken3
http://codereview.appspot.com/174042

Expand All Messages | Collapse All Messages