Issue 173540043: code review 173540043: go/pointer: fix two crashes caused by 'print()'.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 173540043: code review 173540043: go/pointer: fix two crashes caused by 'print()'. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by adonovan

Modified:
9 years, 5 months ago

Reviewers:
crawshaw

CC:
crawshaw, golang-codereviews

Visibility:
Public.

Description

go/pointer: fix two crashes caused by 'print()'. + Test.

Patch Set 1 #

Patch Set 2 : diff -r 0431b49275be692e8934fe50c2da3e0541e06589 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 0431b49275be692e8934fe50c2da3e0541e06589 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 0431b49275be692e8934fe50c2da3e0541e06589 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 0431b49275be692e8934fe50c2da3e0541e06589 https://code.google.com/p/go.tools #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
M	go/pointer/gen.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	go/pointer/pointer_test.go	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	go/pointer/testdata/another.go	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello crawshaw@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

9 years, 5 months ago (2014-11-20 18:01:29 UTC) #1

adonovan

9 years, 5 months ago (2014-11-20 18:33:20 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=5f3a656edf57&repo=tools ***

go/pointer: fix two crashes caused by 'print()'.

+ Test.

LGTM=crawshaw
R=crawshaw
CC=golang-codereviews
https://codereview.appspot.com/173540043

Expand All Messages | Collapse All Messages