code review 173100044: x/net/webdav: add a Dir type, analogous to http.Dir.

x/net/webdav: add a Dir type, analogous to http.Dir.

[nigeltao, 2014-11-12 07:41:57]

Hello dave@cheney.net (cc: bradfitz@golang.org, dr.volker.dobler@gmail.com,
golang-codereviews@googlegroups.com, nmvc@google.com,
robert.stepanek@gmail.com),

I'd like you to review this change to
https://code.google.com/p/go.net

[nmvc, 2014-11-13 02:33:41]

https://codereview.appspot.com/173100044/diff/40001/webdav/file.go
File webdav/file.go (right):

https://codereview.appspot.com/173100044/diff/40001/webdav/file.go#newcode23
webdav/file.go:23: Mkdir(name string, perm os.FileMode) error
I assume this change was to avoid clash with the package name?

https://codereview.appspot.com/173100044/diff/40001/webdav/file.go#newcode74
webdav/file.go:74: // TODO: check if name == filepath.Clean(string(d)) and
prohibit removing the root?
+1 to that idea, as all operations will then fail and you can't Mkdir ""

[nigeltao, 2014-11-13 05:54:27]

https://codereview.appspot.com/173100044/diff/40001/webdav/file.go
File webdav/file.go (right):

https://codereview.appspot.com/173100044/diff/40001/webdav/file.go#newcode23
webdav/file.go:23: Mkdir(name string, perm os.FileMode) error
On 2014/11/13 02:33:41, nmvc wrote:
> I assume this change was to avoid clash with the package name?

Yes.

https://codereview.appspot.com/173100044/diff/40001/webdav/file.go#newcode74
webdav/file.go:74: // TODO: check if name == filepath.Clean(string(d)) and
prohibit removing the root?
On 2014/11/13 02:33:41, nmvc wrote:
> +1 to that idea, as all operations will then fail and you can't Mkdir ""

Done.

[nmvc, 2014-11-13 23:37:27]

LGTM

[dave_cheney.net, 2014-11-13 23:53:38]

On 2014/11/13 23:37:27, nmvc wrote:
> LGTM

LGTM

[nigeltao, 2014-11-14 00:47:53]

*** Submitted as
https://code.google.com/p/go/source/detail?r=870131cdf8c5&repo=net ***

x/net/webdav: add a Dir type, analogous to http.Dir.

LGTM=nmvc, dave
R=dave, nmvc
CC=bradfitz, dr.volker.dobler, golang-codereviews, robert.stepanek
https://codereview.appspot.com/173100044