Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(328)

Issue 1729052: code review 1729052: http: add https client support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by fhs
Modified:
13 years, 8 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

http: add https client support Fixes issue 851.

Patch Set 1 #

Patch Set 2 : code review 1729052: http: add https client support #

Patch Set 3 : code review 1729052: http: add https client support #

Total comments: 2

Patch Set 4 : code review 1729052: http: add https client support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/pkg/crypto/tls/handshake_client.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/http/client.go View 1 2 3 4 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 6
fhs
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 8 months ago (2010-07-16 09:11:47 UTC) #1
fhs
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 8 months ago (2010-07-16 09:19:08 UTC) #2
rsc1
https client support sounds great but it's not helpful unless the crypto/tls package verifies certificates. ...
13 years, 8 months ago (2010-07-16 18:16:02 UTC) #3
fhs
PTAL On 2010/07/16 18:16:02, rsc1 wrote: > https client support sounds great but > it's ...
13 years, 8 months ago (2010-07-16 23:26:18 UTC) #4
rsc1
LGTM
13 years, 8 months ago (2010-07-29 01:11:13 UTC) #5
rsc
13 years, 8 months ago (2010-07-29 01:13:59 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=bd602ec4b638 ***

http: add https client support

Fixes issue 851.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1729052

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b