Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(886)

Issue 1729051: code review 1729051: gc: bug292 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by rsc
Modified:
14 years, 8 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: bug292 Fixes issue 843.

Patch Set 1 #

Patch Set 2 : code review 1729051: gc: bug292 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M src/cmd/gc/go.h View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/print.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/typecheck.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/unsafe.c View 4 chunks +16 lines, -4 lines 0 comments Download
A test/fixedbugs/bug292.go View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 8 months ago (2010-07-15 23:13:45 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=727e201e6697 *** gc: bug292 Fixes issue 843. R=ken2 CC=golang-dev http://codereview.appspot.com/1729051
14 years, 8 months ago (2010-07-15 23:13:49 UTC) #2
ken3
14 years, 8 months ago (2010-07-16 00:12:52 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b