Issue 172900043: code review 172900043: go.net/ipv6: disable full stack tests on nacl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 172900043: code review 172900043: go.net/ipv6: disable full stack tests on nacl (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by mikio

Modified:
10 years, 4 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

x/net/ipv6: disable full stack tests on nacl

Patch Set 1 : diff -r 34976018d4f0cf09061e2ab776fe46f2f3249a12 https://code.google.com/p/go.net #

Patch Set 2 : diff -r b0f414cf1bd92cd3979ebbf908afd5c91fbe5469 https://code.google.com/p/go.net #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -19 lines)			Patch
M	ipv6/icmp_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ipv6/multicast_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ipv6/multicastlistener_test.go	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	ipv6/multicastsockopt_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipv6/readwrite_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipv6/sockopt_test.go	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	ipv6/unicast_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ipv6/unicastsockopt_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

10 years, 4 months ago (2014-11-09 14:27:43 UTC) #1

mikio

10 years, 4 months ago (2014-11-10 00:47:53 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=351137ba2654&repo=net ***

x/net/ipv6: disable full stack tests on nacl

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/172900043

Expand All Messages | Collapse All Messages