Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9867)

Issue 172620043: code review 172620043: x/talks/2014/static-analysis: add build tags to exclude... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by dsymonds
Modified:
9 years, 5 months ago
Reviewers:
adg1
CC:
adg, adonovan, adg1, golang-codereviews
Visibility:
Public.

Description

x/talks/2014/static-analysis: add build tags to exclude demo source code from the build.

Patch Set 1 #

Patch Set 2 : diff -r 7c7aec7a1d4a56296897102f0e87423ff3409bc5 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 7c7aec7a1d4a56296897102f0e87423ff3409bc5 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 7c7aec7a1d4a56296897102f0e87423ff3409bc5 https://code.google.com/p/go.talks #

Patch Set 5 : diff -r 7c7aec7a1d4a56296897102f0e87423ff3409bc5 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M 2014/static-analysis/demo.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/static-analysis/fib.go View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/static-analysis/hello.go View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M 2014/static-analysis/template.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6
dsymonds
Hello adg, adonovan (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
9 years, 5 months ago (2014-11-17 04:10:11 UTC) #1
dsymonds
Hello adg@golang.org, adonovan@google.com (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 5 months ago (2014-11-17 04:11:19 UTC) #2
adg1
LGTM
9 years, 5 months ago (2014-11-17 04:32:45 UTC) #3
dsymonds
*** Submitted as https://code.google.com/p/go/source/detail?r=971fb99732b6&repo=talks *** x/talks/2014/static-analysis: add build tags to exclude demo source code from ...
9 years, 5 months ago (2014-11-17 05:43:50 UTC) #4
adonovan
Sorry about that; thanks for the fix. BTW, what causes the talks.golang.org site to reflect ...
9 years, 5 months ago (2014-11-17 16:23:45 UTC) #5
adg1
9 years, 5 months ago (2014-11-17 21:20:15 UTC) #6
You need to run //go/golang/talks/deploy.sh
I'll do it when I get into the office, if nobody beats me to it

On Tue Nov 18 2014 at 3:23:45 AM Alan Donovan <adonovan@google.com> wrote:

> Sorry about that; thanks for the fix.
>
> BTW, what causes the talks.golang.org site to reflect the change?
>
> On 17 November 2014 00:43, <dsymonds@golang.org> wrote:
>
>> *** Submitted as
>> https://code.google.com/p/go/source/detail?r=971fb99732b6&repo=talks ***
>>
>> x/talks/2014/static-analysis: add build tags to exclude demo source code
>> from the build.
>>
>> LGTM=adg
>> R=adg, adonovan
>> CC=golang-codereviews
>> https://codereview.appspot.com/172620043
>>
>>
>> https://codereview.appspot.com/172620043/
>>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b