Issue 172360043: code review 172360043: x/net/ipv4: fix freebsd/{386,arm} build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 172360043: code review 172360043: x/net/ipv4: fix freebsd/{386,arm} build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by mikio

Modified:
9 years, 5 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

x/net/ipv4: fix freebsd/{386,arm}, linux/{386,arm} build

Patch Set 1 : diff -r 9ad12cda6090972102e506f57756875cb48dabf1 https://code.google.com/p/go.net #

Patch Set 2 : diff -r 9ad12cda6090972102e506f57756875cb48dabf1 https://code.google.com/p/go.net #

Patch Set 3 : diff -r e3315e53f6e3bd6f1d7631c562e1ec1b22bfd4ec https://code.google.com/p/go.net #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+441 lines, -13 lines)			Patch
M	ipv4/defs_linux.go	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	ipv4/gen.go	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
A	ipv4/zsys_freebsd_386.go	View		1 chunk	+93 lines, -0 lines	0 comments	Download
M	ipv4/zsys_freebsd_amd64.go	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	ipv4/zsys_freebsd_arm.go	View		1 chunk	+93 lines, -0 lines	0 comments	Download
A	ipv4/zsys_linux_386.go	View	1	1 chunk	+122 lines, -0 lines	0 comments	Download
M	ipv4/zsys_linux_amd64.go	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
A	ipv4/zsys_linux_arm.go	View	1	1 chunk	+122 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

9 years, 5 months ago (2014-11-12 12:10:17 UTC) #1

mikio

9 years, 5 months ago (2014-11-12 22:19:48 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=d9450cd5deca&repo=net ***

x/net/ipv4: fix freebsd/{386,arm}, linux/{386,arm} build

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/172360043

Expand All Messages | Collapse All Messages