Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(65)

Issue 172100043: code review 172100043: go.crypto/ssh/terminal: fix Home and End. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by agl1
Modified:
9 years, 5 months ago
Reviewers:
bradfitz
CC:
bradfitz, golang-codereviews
Visibility:
Public.

Description

go.crypto/ssh/terminal: fix Home and End. In my notes I had Home and End down as OH and OF. But that's nonsense, they are [H and ]F. I never noticed before because I don't have Home and End keys on my keyboard.

Patch Set 1 #

Patch Set 2 : diff -r 841f0a993ddddfbf3648cac422c219d0752b280a https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 841f0a993ddddfbf3648cac422c219d0752b280a https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r 88f995681294397936c136182f54e1f6891db323 https://code.google.com/p/go.crypto/ #

Patch Set 5 : diff -r 88f995681294397936c136182f54e1f6891db323 https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M ssh/terminal/terminal.go View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3
agl1
Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
9 years, 5 months ago (2014-11-07 19:49:14 UTC) #1
bradfitz
LGTM On Fri, Nov 7, 2014 at 4:49 PM, <agl@golang.org> wrote: > Reviewers: bradfitz, > ...
9 years, 5 months ago (2014-11-07 20:49:36 UTC) #2
agl1
9 years, 5 months ago (2014-11-08 03:20:30 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=7ad4bae3f467&repo=crypto ***

go.crypto/ssh/terminal: fix Home and End.

In my notes I had Home and End down as OH and OF. But that's nonsense, they are
[H and ]F.
I never noticed before because I don't have Home and End keys on my keyboard.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/172100043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b