Issue 172049: code review 172049: gc: semicolons

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 172049: code review 172049: gc: semicolons (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by rsc

Modified:
15 years, 3 months ago

Reviewers:

CC:
ken2, ken3, golang-dev

Visibility:
Public.

Description

gc: semicolons Fixes issue 89. Fixes issue 92. Fixes issue 118. Fixes issue 182. Fixes issue 328. Fixes issue 340.

Patch Set 1 #

Patch Set 2 : code review 172049: gc: semicolons #

Patch Set 3 : code review 172049: gc: semicolons #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -164 lines)			Patch
M	src/cmd/gc/go.h	View	1 2	3 chunks	+1 line, -5 lines	0 comments	Download
M	src/cmd/gc/go.y	View		26 chunks	+43 lines, -78 lines	0 comments	Download
M	src/cmd/gc/lex.c	View	1 2	10 chunks	+58 lines, -81 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 3 months ago (2009-12-10 07:58:48 UTC) #1

rsc

Note: not submitting this until gofmt can reformat the over-commented example from the other thread, ...

15 years, 3 months ago (2009-12-10 08:00:24 UTC) #2

ken3

On 2009/12/10 08:00:24, rsc wrote: > Note: not submitting this until gofmt can reformat > ...

15 years, 3 months ago (2009-12-10 20:29:26 UTC) #3

rsc

15 years, 3 months ago (2009-12-11 23:59:44 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=26b9258d76e4 ***

gc: semicolons

Fixes issue 89.
Fixes issue 92.
Fixes issue 118.
Fixes issue 182.
Fixes issue 328.
Fixes issue 340.

R=ken2, ken3
CC=golang-dev
http://codereview.appspot.com/172049

Expand All Messages | Collapse All Messages